From: Florian Müllner <fmuellner@gnome.org>
Date: Thu, 11 Jul 2024 17:21:05 +0000 (+0200)
Subject: lookingGlass: Stop setting font programmatically
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~226^2^2~39
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=6f2c99147c00a989c0a47e69327b2943a39e29d8;p=gnome-shell.git

lookingGlass: Stop setting font programmatically

Instead, use CSS to request a monospace font selectively where
it makes sense (the evaluator).

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7776
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3413>
---

diff --git a/data/theme/gnome-shell-sass/widgets/_looking-glass.scss b/data/theme/gnome-shell-sass/widgets/_looking-glass.scss
index 53cf74fff..d7583b480 100644
--- a/data/theme/gnome-shell-sass/widgets/_looking-glass.scss
+++ b/data/theme/gnome-shell-sass/widgets/_looking-glass.scss
@@ -88,6 +88,10 @@
   &:hover { border: 1px solid $fg_color; }
 }
 
+#EvalBox {
+  @extend %monospace;
+}
+
 // Extensions
 #lookingGlassExtensions { padding: $base_padding; }
 
diff --git a/js/ui/lookingGlass.js b/js/ui/lookingGlass.js
index e3b0de7a2..987700877 100644
--- a/js/ui/lookingGlass.js
+++ b/js/ui/lookingGlass.js
@@ -1296,11 +1296,6 @@ class LookingGlass extends St.BoxLayout {
         // Sort of magic, but...eh.
         this._maxItems = 150;
 
-        this._interfaceSettings = new Gio.Settings({schema_id: 'org.gnome.desktop.interface'});
-        this._interfaceSettings.connect('changed::monospace-font-name',
-            this._updateFont.bind(this));
-        this._updateFont();
-
         // We want it to appear to slide out from underneath the panel
         Main.uiGroup.add_child(this);
         Main.uiGroup.set_child_below_sibling(this,
@@ -1438,18 +1433,6 @@ class LookingGlass extends St.BoxLayout {
         return Clutter.EVENT_PROPAGATE;
     }
 
-    _updateFont() {
-        let fontName = this._interfaceSettings.get_string('monospace-font-name');
-        let fontDesc = Pango.FontDescription.from_string(fontName);
-        // We ignore everything but size and style; you'd be crazy to set your system-wide
-        // monospace font to be bold/oblique/etc. Could easily be added here.
-        let size = fontDesc.get_size() / 1024.;
-        let unit = fontDesc.get_size_is_absolute() ? 'px' : 'pt';
-        this.style = `
-            font-size: ${size}${unit};
-            font-family: "${fontDesc.get_family()}";`;
-    }
-
     setBorderPaintTarget(obj) {
         if (this._borderPaintTarget != null)
             this._borderPaintTarget.remove_effect(this._redBorderEffect);